From bb1f85183b94f3c8343dc3614f1de62a660e9fe5 Mon Sep 17 00:00:00 2001 From: Henrik Raitasola Date: Thu, 23 Feb 2017 17:04:07 -0800 Subject: [PATCH] Add TextInput's prop caretHidden implementation for Android and add the prop to docs Summary: This PR will: - add missing documentation for `caretHidden` prop to the docs - add `caretHidden` prop implementation for Android I noticed this by accident when looking at `RCTTextFieldManager.m` and there is `RCT_EXPORT_VIEW_PROPERTY(caretHidden, BOOL)` which hides caret on iOS. Then I realised that the docs were missing for this prop and implementation on Android side :) Render `TextInput` with prop `caretHidden`. After this caret is not visible anymore. `` If you omit the prop then caret is visible again `` Closes https://github.com/facebook/react-native/pull/11863 Differential Revision: D4448402 fbshipit-source-id: 456e1df3e2cbb8af32540d2c7a8f4e7da219f5c3 --- Libraries/Components/TextInput/TextInput.js | 4 ++++ .../react/views/textinput/ReactTextInputManager.java | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/Libraries/Components/TextInput/TextInput.js b/Libraries/Components/TextInput/TextInput.js index 7bccf38b9..1c70e412a 100644 --- a/Libraries/Components/TextInput/TextInput.js +++ b/Libraries/Components/TextInput/TextInput.js @@ -527,6 +527,10 @@ const TextInput = React.createClass({ PropTypes.oneOf(DataDetectorTypes), PropTypes.arrayOf(PropTypes.oneOf(DataDetectorTypes)), ]), + /** + * If `true`, caret is hidden. The default value is `false`. + */ + caretHidden: PropTypes.bool, }, /** diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java index e91f681af..37edf2ec6 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java @@ -346,6 +346,11 @@ public class ReactTextInputManager extends BaseViewManager