From b8a5136d2201049370132810d13aab4c69e81089 Mon Sep 17 00:00:00 2001 From: Mehdi Mulani Date: Thu, 2 Nov 2017 08:44:10 -0700 Subject: [PATCH] Fix memory leak in RCTSafeAreaView Summary: According to the retain code collector, RCTSafeAreaView is in a cycle: -> _bridge -> RCTCxxBridge -> _moduleDataByName -> __NSDictionaryM -> RCTModuleData -> _instance -> RCTUIManager -> _viewRegistry -> __NSDictionaryM -> RCTSafeAreaView This should break the cycle. Reviewed By: shergin Differential Revision: D6213668 fbshipit-source-id: efb9c1dd148b72f66fe4485b81c16cd4c2d18b17 --- React/Views/SafeAreaView/RCTSafeAreaView.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/React/Views/SafeAreaView/RCTSafeAreaView.m b/React/Views/SafeAreaView/RCTSafeAreaView.m index 3cf1494f3..971408ae2 100644 --- a/React/Views/SafeAreaView/RCTSafeAreaView.m +++ b/React/Views/SafeAreaView/RCTSafeAreaView.m @@ -15,7 +15,7 @@ #import "RCTSafeAreaViewLocalData.h" @implementation RCTSafeAreaView { - RCTBridge *_bridge; + __weak RCTBridge *_bridge; UIEdgeInsets _currentSafeAreaInsets; }