From b273516b02414daf13493e5c0ea4b6aa848ddf14 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Wed, 1 May 2019 10:43:42 -0700 Subject: [PATCH] Making UITemplateProcessorTest not instrumentation Summary: Instrumentation tests are expensive and flaky. Luckly this one does not need to be instrumentation one. Reviewed By: mdvacca Differential Revision: D15158985 fbshipit-source-id: 3c88e5a0d82db2cd00f5866c3f9956409cc8fc7f --- ReactCommon/fabric/uimanager/BUCK | 2 -- .../fabric/uimanager/tests/UITemplateProcessorTest.cpp | 10 ---------- 2 files changed, 12 deletions(-) diff --git a/ReactCommon/fabric/uimanager/BUCK b/ReactCommon/fabric/uimanager/BUCK index 359f3b9e2..a04c71a69 100644 --- a/ReactCommon/fabric/uimanager/BUCK +++ b/ReactCommon/fabric/uimanager/BUCK @@ -76,7 +76,6 @@ fb_xplat_cxx_test( "-Wall", ], contacts = ["oncall+react_native@xmail.facebook.com"], - fbandroid_use_instrumentation_test = True, platforms = (ANDROID, APPLE), deps = [ "fbsource//xplat/folly:molly", @@ -87,7 +86,6 @@ fb_xplat_cxx_test( react_native_xplat_target("fabric/components/image:image"), react_native_xplat_target("fabric/components/root:root"), react_native_xplat_target("fabric/components/scrollview:scrollview"), - react_native_xplat_target("fabric/components/text:text"), react_native_xplat_target("fabric/components/view:view"), "fbsource//xplat/js/react-native-github:generated_components-rncore", ], diff --git a/ReactCommon/fabric/uimanager/tests/UITemplateProcessorTest.cpp b/ReactCommon/fabric/uimanager/tests/UITemplateProcessorTest.cpp index 27bb387df..8af2d3636 100644 --- a/ReactCommon/fabric/uimanager/tests/UITemplateProcessorTest.cpp +++ b/ReactCommon/fabric/uimanager/tests/UITemplateProcessorTest.cpp @@ -17,9 +17,6 @@ using namespace facebook::react; #include #include #include -#include -#include -#include #include #include #include @@ -41,13 +38,6 @@ ComponentRegistryFactory getDefaultComponentRegistryFactory() { eventDispatcher, contextContainer)); registry->registerComponentDescriptor( std::make_shared(eventDispatcher)); - registry->registerComponentDescriptor( - std::make_shared( - eventDispatcher, contextContainer)); - registry->registerComponentDescriptor( - std::make_shared(eventDispatcher)); - registry->registerComponentDescriptor( - std::make_shared(eventDispatcher)); registry->registerComponentDescriptor( std::make_shared( eventDispatcher));