kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-29 21:46:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: LayoutableShadowNodeList::getChildren renamed to getLayoutableChildNodes

Browse Source 
Summary:
The previous name conflicts with the method with same (but with different semantic) name in `ShadowNode` class.
That was bad idea to use same name especially because the different semantic.

Reviewed By: fkgozali

Differential Revision: D7554549

fbshipit-source-id: 0bccbaacd0812f8a26592b2008f15ddb5bc34ebc
This commit is contained in:
Valentin Shergin
2018-04-10 16:37:22 -07:00
committed by Facebook Github Bot
parent 711abeda79
commit b13d5beb11
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactCommon/fabric/core/layout/LayoutableShadowNode.cpp
View File

@@ -64,7 +64,7 @@ Float LayoutableShadowNode::lastBaseline(Size size) const {
void LayoutableShadowNode::layout(LayoutContext layoutContext) {
layoutChildren(layoutContext);
for (auto child : getChildren()) {
for (auto child : getLayoutableChildNodes()) {
if (!child->getHasNewLayout()) {
continue;
}

2
ReactCommon/fabric/core/layout/LayoutableShadowNode.h
View File

@@ -88,7 +88,7 @@ protected:
/*
* Returns layoutable children to interate on.
*/
virtual SharedLayoutableShadowNodeList getChildren() const = 0;
virtual SharedLayoutableShadowNodeList getLayoutableChildNodes() const = 0;
/*
* In case layout algorithm needs to mutate this (probably sealed) node,