Fixed border smearing issue

Browse Source

Summary:
public
The iOS border rendering code did not follow the CSS spec in cases where the sum of adjacent border radii was greater than the width of the view, resulting in drawing glitches such as pixel smear and borders appearing stretched or squashed.

This diff brings our implementation closer to spec-compliance in these cases. I also fixed a longstanding issue with ghostly diagonal lines appearing at the corners due to antialiasing rounding errors!

Fixes

https://github.com/facebook/react-native/issues/1572
https://github.com/facebook/react-native/issues/2089
https://github.com/facebook/react-native/issues/4604

Reviewed By: tadeuzagallo

Differential Revision: D2811249

fb-gh-sync-id: c3dd2721e0a01a432fa4dc78daa05680595edd08

...

This commit is contained in:

Nick Lockwood

2016-01-07 09:48:15 -08:00

committed by facebook-github-bot-3

parent abb81eb270

commit b115277d00

6 changed files with 77 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

Examples/UIExplorer/UIExplorerIntegrationTests/ReferenceImages/Examples-UIExplorer-UIExplorerApp.ios/testLayoutExample_1@2x.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 73 KiB After Width:  |  Height:  |  Size: 128 KiB

BIN

Examples/UIExplorer/UIExplorerIntegrationTests/ReferenceImages/Examples-UIExplorer-UIExplorerApp.ios/testSwitchExample_1@2x.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 87 KiB After Width:  |  Height:  |  Size: 147 KiB

BIN

Examples/UIExplorer/UIExplorerIntegrationTests/ReferenceImages/Examples-UIExplorer-UIExplorerApp.ios/testTextExample_1@2x.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 277 KiB After Width:  |  Height:  |  Size: 360 KiB

BIN

Examples/UIExplorer/UIExplorerIntegrationTests/ReferenceImages/Examples-UIExplorer-UIExplorerApp.ios/testViewExample_1@2x.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 153 KiB After Width:  |  Height:  |  Size: 153 KiB