From adde2ed5e92f22c93e254633f003c68c945eac9a Mon Sep 17 00:00:00 2001 From: Alexey Lang Date: Wed, 4 Oct 2017 14:58:23 -0700 Subject: [PATCH] Fix the debug logging regression Reviewed By: AaaChiuuu Differential Revision: D5975880 fbshipit-source-id: 39c632ddf84e57c814b54fac465651120e4127da --- .../react/bridge/JavaMethodWrapper.java | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaMethodWrapper.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaMethodWrapper.java index 8caf629bf..63af54d2a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaMethodWrapper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaMethodWrapper.java @@ -135,6 +135,9 @@ public class JavaMethodWrapper implements NativeModule.NativeMethod { } }; + private static final boolean DEBUG = + PrinterHolder.getPrinter().shouldDisplayLogMessage(ReactDebugOverlayTags.BRIDGE_CALLS); + private static char paramTypeToChar(Class paramClass) { char tryCommon = commonTypeToChar(paramClass); if (tryCommon != '\0') { @@ -332,12 +335,14 @@ public class JavaMethodWrapper implements NativeModule.NativeMethod { SystraceMessage.beginSection(TRACE_TAG_REACT_JAVA_BRIDGE, "callJavaModuleMethod") .arg("method", traceName) .flush(); - PrinterHolder.getPrinter() - .logMessage( - ReactDebugOverlayTags.BRIDGE_CALLS, - "JS->Java: %s.%s()", - mModuleWrapper.getName(), - mMethod.getName()); + if (DEBUG) { + PrinterHolder.getPrinter() + .logMessage( + ReactDebugOverlayTags.BRIDGE_CALLS, + "JS->Java: %s.%s()", + mModuleWrapper.getName(), + mMethod.getName()); + } try { if (!mArgumentsProcessed) { processArguments();