mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-05-01 06:22:39 +08:00
Remove referenced to dropped views
Summary: There is currently a bug where we never release any Views that no longer display, still storing hard references in NativeViewHierarchyManager. This diff is fixing this bug, and here is how: a) there is already logic in place to drop FlatShadowNodes (UIImplementation.removeShadowNode). b) there is already logic in place to drop Views (NativeViewHierarchyManager.dropView(int reactTag) - used to private but needs to be protected so I can call it) c) (the missing part) when we are about to drop a FlatShadowNode, check if it mount to a View (i.e. there is a View associated with that node), put it into a ArrayList. When we finished updates to a nodes hierarchy (which happens in non-UI thread), collect ids from those nodes and enqueue a UIOperation that will drop all the Views. We can either forward nodes as FlatShadowNode[], or only ids as int[]. Both should be fine, but as a rule of thumb we don't touch shadow node hierarchy from UI thread (as we don't touch Views from non-UI thread) so passing int[] is what this code is doing. Reviewed By: ahmedre Differential Revision: D2757310
This commit is contained in:
committed by
Ahmed El-Helw
parent
e9753a11ae
commit
ad65b2a9e1
@@ -128,6 +128,20 @@ import com.facebook.react.uimanager.UIViewOperationQueue;
|
||||
}
|
||||
}
|
||||
|
||||
private final class DropViews implements UIOperation {
|
||||
|
||||
private final int[] mViewsToDrop;
|
||||
|
||||
private DropViews(int[] viewsToDrop) {
|
||||
mViewsToDrop = viewsToDrop;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void execute() {
|
||||
mNativeViewHierarchyManager.dropViews(mViewsToDrop);
|
||||
}
|
||||
}
|
||||
|
||||
public final class DetachAllChildrenFromViews implements UIViewOperationQueue.UIOperation {
|
||||
private @Nullable int[] mViewsToDetachAllChildrenFrom;
|
||||
|
||||
@@ -181,6 +195,10 @@ import com.facebook.react.uimanager.UIViewOperationQueue;
|
||||
new SetPadding(reactTag, paddingLeft, paddingTop, paddingRight, paddingBottom));
|
||||
}
|
||||
|
||||
public void enqueueDropViews(int[] viewsToDrop) {
|
||||
enqueueUIOperation(new DropViews(viewsToDrop));
|
||||
}
|
||||
|
||||
public DetachAllChildrenFromViews enqueueDetachAllChildrenFromViews() {
|
||||
DetachAllChildrenFromViews op = new DetachAllChildrenFromViews();
|
||||
enqueueUIOperation(op);
|
||||
|
||||
Reference in New Issue
Block a user