kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-11 22:32:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix retain cycle

Browse Source 
Summary:
public

This fixes the following circular reference:

RCTComponentData
-> _bridge -> RCTBatchedBridge
-> _moduleDataByName -> __NSDictionaryI
-> RCTModuleData
-> _instance -> RCTUIManager
-> _componentDataByName -> __NSDictionaryI
-> RCTComponentData

Reviewed By: javache

Differential Revision: D2744742

fb-gh-sync-id: c282786f4dfb550185bc03d3e5e3d03048664c21
This commit is contained in:
Nick Lockwood
2015-12-10 12:04:53 -08:00
committed by facebook-github-bot-2
parent 88ac40666c
commit ac783a8a1b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
React/Views/RCTComponentData.h
View File

@@ -21,7 +21,7 @@
@property (nonatomic, readonly) Class managerClass;
@property (nonatomic, copy, readonly) NSString *name;
@property (nonatomic, strong, readonly) RCTViewManager *manager;
@property (nonatomic, weak, readonly) RCTViewManager *manager;
- (instancetype)initWithManagerClass:(Class)managerClass
bridge:(RCTBridge *)bridge NS_DESIGNATED_INITIALIZER;

2
React/Views/RCTComponentData.m
View File

@@ -44,7 +44,7 @@ typedef void (^RCTPropBlock)(id<RCTComponent> view, id json);
RCTShadowView *_defaultShadowView;
NSMutableDictionary<NSString *, RCTPropBlock> *_viewPropBlocks;
NSMutableDictionary<NSString *, RCTPropBlock> *_shadowPropBlocks;
RCTBridge *_bridge;
__weak RCTBridge *_bridge;
}
@synthesize manager = _manager;