kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-24 04:16:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix React Native AsyncMode and DevTools

Browse Source 
Summary:
Fixes two problems I uncovered with React Native:
1. `FBCore/Prelude` points to `React.unstable_AsyncMode` which is not defined. (This type was renamed to `React.unstable_ConcurrentMode` in React v16.6.0. **As a result** people in the "react_native:async_rendering" GK will no longer get runtime errors on app start.
2. Updates `react-devtools` and (more importantly) `react-devtools-core` to 3.4.2 to handle the React-internal tag/type refactoring that happened prior to the release of 16.6.0. **As a result** DevTools will no longer cause a runtime error when connected to React Native.

For the second change, I ran `js1 upgrade react-devtools -v ^3.4.2`

Reviewed By: sebmarkbage

Differential Revision: D13030590

fbshipit-source-id: 603f7f6259f282839039820bcdba4310064a7965
This commit is contained in:
Brian Vaughn
2018-11-15 09:23:56 -08:00
committed by Facebook Github Bot
parent 619de16661
commit aacb06c594
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/ReactNative/renderApplication.js
View File

@@ -49,8 +49,8 @@ function renderApplication<Props: Object>(
RootComponent.prototype.unstable_isAsyncReactComponent === true
) {
// $FlowFixMe This is not yet part of the official public API
const AsyncMode = React.unstable_AsyncMode;
renderable = <AsyncMode>{renderable}</AsyncMode>;
const ConcurrentMode = React.unstable_ConcurrentMode;
renderable = <ConcurrentMode>{renderable}</ConcurrentMode>;
}
if (fabric) {