From aa85408f568ae9776fef99dcae317def0a07139a Mon Sep 17 00:00:00 2001 From: Adam Comella Date: Tue, 22 Nov 2016 10:52:37 -0800 Subject: [PATCH] Android: Fix inconsistency with fractional TextInput padding Summary: TextInput rounds padding down with `floor` when measuring. However, it rounds padding up with `ceil` when rendering. This change makes things consistent by moving TextInput's rendering code to use `floor` as well. It looks like this is the intended behavior because commit bdff10b moved measuring from `ceil` to `floor`. It looks like TextInput's rendering code was just overlooked in that commit. **Test plan (required)** Verified TextInput padding works in a test app. Also, my team uses this change in our app. Adam Comella Microsoft Corp. Closes https://github.com/facebook/react-native/pull/11003 Differential Revision: D4220855 Pulled By: mkonicek fbshipit-source-id: 95349867ef89c021a8441b383a09052ca0dd569c --- .../react/views/textinput/ReactTextInputManager.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java index 2a2cf446c..50d20631b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java @@ -164,10 +164,10 @@ public class ReactTextInputManager extends BaseViewManager