From a87b9db3dc3942ecb6e41f374368a74e9729ea6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20H=C3=B6nig?= Date: Mon, 16 Jul 2018 22:19:09 -0700 Subject: [PATCH] Fix wrong time unit in dev server OKHttp client. (#19817) Summary: The keep-alive-duration for the connection pool for mOnChangePollingClient is a number in milliseconds, but was mistakenly given in minutes. This mistake was introduced in 6bbaff2944d. I discovered this by chance while lurking around in the codebase. Pull Request resolved: https://github.com/facebook/react-native/pull/19817 Differential Revision: D8873138 Pulled By: hramos fbshipit-source-id: c81c1952721449442f18a0c2373f8b2780403749 --- .../java/com/facebook/react/devsupport/DevServerHelper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java index b1342c055..255a895fc 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java @@ -539,7 +539,7 @@ public class DevServerHelper { mOnChangePollingEnabled = true; mOnServerContentChangeListener = onServerContentChangeListener; mOnChangePollingClient = new OkHttpClient.Builder() - .connectionPool(new ConnectionPool(1, LONG_POLL_KEEP_ALIVE_DURATION_MS, TimeUnit.MINUTES)) + .connectionPool(new ConnectionPool(1, LONG_POLL_KEEP_ALIVE_DURATION_MS, TimeUnit.MILLISECONDS)) .connectTimeout(HTTP_CONNECT_TIMEOUT_MS, TimeUnit.MILLISECONDS) .build(); enqueueOnChangeEndpointLongPolling();