kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-13 03:49:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

TextInput: selection property was unified

Browse Source 
Summary:
This diff unifies `selection` prop between single line and multi line text inputs.
Besides that, this diff improves the selection event handling, makes it more robust and predictable.
(See inline comments.)

Reviewed By: mmmulani

Differential Revision: D5317652

fbshipit-source-id: db5b0d2c0b80268e479ba866980e14b444079386
This commit is contained in:
Valentin Shergin
2017-07-18 14:33:45 -07:00
committed by Facebook Github Bot
parent 4ff3e101ac
commit a50c9c8e22
11 changed files with 132 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/Text/RCTBackedTextInputViewProtocol.h
View File

@@ -23,4 +23,12 @@
@property (nonatomic, strong, nullable) UIView *inputAccessoryView;
@property (nonatomic, weak, nullable) id<RCTBackedTextInputDelegate> textInputDelegate;
// This protocol disallows direct access to `selectedTextRange` property because
// unwise usage of it can break the `delegate` behavior. So, we always have to
// explicitly specify should `delegate` be notified about the change or not.
// If the change was initiated programmatically, we must NOT notify the delegate.
// If the change was a result of user actions (like typing or touches), we MUST notify the delegate.
- (void)setSelectedTextRange:(nullable UITextRange *)selectedTextRange NS_UNAVAILABLE;
- (void)setSelectedTextRange:(nullable UITextRange *)selectedTextRange notifyDelegate:(BOOL)notifyDelegate;
@end