From a17797940dc6ee5acbcdf115c591ffbc53c0927c Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Wed, 13 Sep 2017 14:31:06 -0700 Subject: [PATCH] Fixed issue with remeasuring ReactTextShadowNode Summary: This fixes the regression recently introduced during refactoring of text-related classes. So, added fragment of code was lost in D5715830. See how it looked before: https://github.com/facebook/react-native/blob/9f5bdd7b497427506dab753ed12017900cb5ffe7/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java#L424-L431 Reviewed By: TheSavior Differential Revision: D5827424 fbshipit-source-id: 5df99620057ff6a27105dd05903c7f5def85c5d2 --- .../com/facebook/react/views/text/ReactTextShadowNode.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java index 7f9745d48..6bd12cc69 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java @@ -168,6 +168,13 @@ public class ReactTextShadowNode extends ReactBaseTextShadowNode { return true; } + @Override + public void markUpdated() { + super.markUpdated(); + // Telling to Yoga that the node should be remeasured on next layout pass. + super.dirty(); + } + @Override public void onCollectExtraUpdates(UIViewOperationQueue uiViewOperationQueue) { super.onCollectExtraUpdates(uiViewOperationQueue);