kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-06 22:44:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Added ColorPropType

Browse Source 
Summary:
Problem: https://github.com/facebook/react-native/issues/4708

Solution: Added a ColorPropType that validates the color used by the dev

Notes:
1) I'm working a Win8.1 machine and couldn't build the react-native using the github repo. As soon as I figure that out, I'll probably figure how to run the tests and how to add some for this feature.
2) It's my first pull request. Be gentle :)
Closes https://github.com/facebook/react-native/pull/4866

Reviewed By: bestander, svcscm

Differential Revision: D2783672

Pulled By: nicklockwood

fb-gh-sync-id: ca22aa3c0999188075681b5d20fff0631496e238
This commit is contained in:
StefanT
2015-12-22 19:29:01 -08:00
committed by facebook-github-bot-3
parent 7164c755cb
commit a162f72655
14 changed files with 78 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js
View File

@@ -10,8 +10,9 @@
*/
'use strict';
var ColorPropType = require('ColorPropType');
var React = require('React');
var RefreshLayoutConsts = require('NativeModules').UIManager.AndroidSwipeRefreshLayout.Constants;
var RefreshLayoutConsts = require('UIManager').AndroidSwipeRefreshLayout.Constants;
var View = require('View');
var onlyChild = require('onlyChild');
@@ -41,11 +42,11 @@ var PullToRefreshViewAndroid = React.createClass({
/**
* The colors (at least one) that will be used to draw the refresh indicator
*/
colors: React.PropTypes.arrayOf(React.PropTypes.string),
colors: React.PropTypes.arrayOf(ColorPropType),
/**
* The background color of the refresh indicator
*/
progressBackgroundColor: React.PropTypes.string,
progressBackgroundColor: ColorPropType,
/**
* Whether the view should be indicating an active refresh
*/