kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-11 10:38:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Breaking change: Move bundle to private-cli

Browse Source 
Summary: @​public

We need to start using the `private-cli` for the new asset system. Note this is a breaking change! People will have to upgrade their workflows/scripts to start using the new cli. Otherwise we'd need to build a thin adapter that is aware of both APIs which is something we;d like to avoid. The major API changes are:
  - API is now `entry-file` based instead of `url` based.
  - /s/--out/--bundle-output
  - /s/--out/--sourcemap-output

Also these parameters have no longer default values, you need to specify them. For instance, if you want to generate the sourcemaps you need to pass in the `--sourcemap-output` option

Lastly, additional project roots or asset roots need to be specified on the `rn-cli.config.js`.

Reviewed By: @frantic

Differential Revision: D2533877

fb-gh-sync-id: a45f9095fdf9442a9106ea7bb6a6b7f651d25273
This commit is contained in:
Martín Bigio
2015-10-13 10:44:00 -07:00
committed by facebook-github-bot-9
parent 793c3564ff
commit a102e6f587
7 changed files with 27 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
local-cli/cli.js
View File

@@ -4,13 +4,13 @@
'use strict';
var bundle = require('../private-cli/src/bundle/bundle');
var bundle_DEPRECATED = require('./bundle.js');
var Config = require('../private-cli/src/util/Config');
var fs = require('fs');
var spawn = require('child_process').spawn;
var path = require('path');
var generateAndroid = require('./generate-android.js');
var init = require('./init.js');
var install = require('./install.js');
var bundle = require('./bundle.js');
var newLibrary = require('./new-library.js');
var runAndroid = require('./run-android.js');
var runPackager = require('./run-packager.js');
@@ -51,7 +51,8 @@ function run() {
install.init();
break;
case 'bundle':
bundle.init(args);
bundle(args, Config.get(__dirname)).done();
// bundle_DEPRECATED.init(args);
break;
case 'new-library':
newLibrary.init(args);