Don't clip overflowing Nodes

Summary:
As of D3235050, Nodes supports the optimization of removing clipped
subviews from the hierarchy. However, because Nodes supports overflow:visible,
this could cause issues when DrawCommands overflow the bounds of their parent
container. This patch fixes this by not clipping any overflowing Nodes.

Reviewed By: astreet

Differential Revision: D3235072
This commit is contained in:
Ahmed El-Helw
2016-05-13 17:49:38 -07:00
parent 5f162ca119
commit 9d67989001
5 changed files with 83 additions and 8 deletions

View File

@@ -325,6 +325,10 @@ import com.facebook.react.uimanager.events.EventDispatcher;
if (nodeRegions != null) {
shouldUpdateMountState = true;
node.setNodeRegions(nodeRegions);
} else if (descendantUpdated) {
// one of the descendant's value for overflows container may have changed, so
// we still need to update ours.
node.updateOverflowsContainer();
}
if (shouldUpdateMountState) {
@@ -332,7 +336,8 @@ import com.facebook.react.uimanager.events.EventDispatcher;
node.getReactTag(),
drawCommands,
listeners,
nodeRegions);
nodeRegions,
node.getOverflowsContainer());
}
if (node.hasUnseenUpdates()) {