Don't clip overflowing Nodes

Summary:
As of D3235050, Nodes supports the optimization of removing clipped
subviews from the hierarchy. However, because Nodes supports overflow:visible,
this could cause issues when DrawCommands overflow the bounds of their parent
container. This patch fixes this by not clipping any overflowing Nodes.

Reviewed By: astreet

Differential Revision: D3235072
This commit is contained in:
Ahmed El-Helw
2016-05-13 17:49:38 -07:00
parent 5f162ca119
commit 9d67989001
5 changed files with 83 additions and 8 deletions

View File

@@ -64,10 +64,11 @@ import com.facebook.react.uimanager.ViewManagerRegistry;
int reactTag,
@Nullable DrawCommand[] drawCommands,
@Nullable AttachDetachListener[] listeners,
@Nullable NodeRegion[] nodeRegions) {
@Nullable NodeRegion[] nodeRegions,
boolean hasOverflowingElements) {
FlatViewGroup view = (FlatViewGroup) resolveView(reactTag);
if (drawCommands != null) {
view.mountDrawCommands(drawCommands);
view.mountDrawCommands(drawCommands, hasOverflowingElements);
}
if (listeners != null) {
view.mountAttachDetachListeners(listeners);