From 9d3f598c2c0a0959f664233de43cd72feae15b71 Mon Sep 17 00:00:00 2001 From: Christoph Nakazawa Date: Fri, 7 Dec 2018 04:47:03 -0800 Subject: [PATCH] Remove references to `local-cli` Summary: This cleans up various configurations after the removal of this folder. Reviewed By: hramos Differential Revision: D13338515 fbshipit-source-id: 9d6877921e15a183e46861626af831231333f42a --- .eslintrc | 13 ------------- .github/CODEOWNERS | 3 --- .npmignore | 3 --- package.json | 6 ++---- react-native-cli/index.js | 2 +- react-native-git-upgrade/cli.js | 2 +- react-native-git-upgrade/cliEntry.js | 3 +-- 7 files changed, 5 insertions(+), 27 deletions(-) delete mode 100644 .npmignore diff --git a/.eslintrc b/.eslintrc index 5cd40ef1d..9c8a0f9d8 100644 --- a/.eslintrc +++ b/.eslintrc @@ -254,19 +254,6 @@ }, "overrides": [ - { - "files": [ - "local-cli/**/*.js", - ], - "rules": { - "lint/extra-arrow-initializer": 0, - "no-alert": 0, - "no-console-disallow": 0, - }, - "env": { - "node": true, - }, - }, { "files": [ "**/__fixtures__/**/*.js", diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b9d084bf8..67886633c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -9,6 +9,3 @@ React/CxxBridge/* @mhorowitz ReactAndroid/src/main/java/com/facebook/react/animated/* @janicduplessis **/*.md @hramos package.json @hramos -local-cli/core/* @grabbou @kureev -local-cli/link/* @grabbou @kureev -local-cli/unlink/* @grabbou @kureev diff --git a/.npmignore b/.npmignore deleted file mode 100644 index 2e0f2c1f8..000000000 --- a/.npmignore +++ /dev/null @@ -1,3 +0,0 @@ -# rnpm -/local-cli/rnpm -/local-cli/server/middleware/heapCapture/bundle.js diff --git a/package.json b/package.json index 0ae410fb1..ac8708210 100644 --- a/package.json +++ b/package.json @@ -90,14 +90,12 @@ ], "testEnvironment": "node", "collectCoverageFrom": [ - "Libraries/**/*.js", - "local-cli/**/*.js" + "Libraries/**/*.js" ], "coveragePathIgnorePatterns": [ "/__tests__/", "/vendor/", - "/Libraries/react-native/", - "/local-cli/templates/" + "/Libraries/react-native/" ] }, "main": "Libraries/react-native/react-native-implementation.js", diff --git a/react-native-cli/index.js b/react-native-cli/index.js index f3d895406..f3bd48f33 100755 --- a/react-native-cli/index.js +++ b/react-native-cli/index.js @@ -21,7 +21,7 @@ // The only job of react-native-cli is to init the repository and then // forward all the commands to the local version of react-native. // -// If you need to add a new command, please add it to local-cli/. +// If you need to add a new command, please add it to react-native-local-cli. // // The only reason to modify this file is to add more warnings and // troubleshooting information for the `react-native init` command. diff --git a/react-native-git-upgrade/cli.js b/react-native-git-upgrade/cli.js index 5f9766782..1de6d6126 100644 --- a/react-native-git-upgrade/cli.js +++ b/react-native-git-upgrade/cli.js @@ -16,7 +16,7 @@ require('babel-register')({ require('babel-preset-stage-3'), ], // Enable transpiling for react-native-git-upgrade AND the generator, just like the upgrade CLI command does - only: /(react-native-git-upgrade\/(?!(node_modules)))|(local-cli\/generator)/, + only: /(react-native-git-upgrade\/(?!(node_modules)))/, }); var cliEntry = require('./cliEntry'); diff --git a/react-native-git-upgrade/cliEntry.js b/react-native-git-upgrade/cliEntry.js index 9a2807293..85c128ba7 100644 --- a/react-native-git-upgrade/cliEntry.js +++ b/react-native-git-upgrade/cliEntry.js @@ -290,8 +290,7 @@ async function run(requestedVersion, cliArgs) { const generatorDir = path.resolve( process.cwd(), 'node_modules', - 'react-native', - 'local-cli', + 'react-native-local-cli', 'generator', ); let projectBackupCreated = false;