kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-22 11:16:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix BUCK bugs which were breaking tests after refactoring

Browse Source 
Reviewed By: johnislarry

Differential Revision: D7874275

fbshipit-source-id: 7f9c8648571bc7f41649ec4ef547e7c34b479221
This commit is contained in:
Marc Horowitz
2018-05-09 22:02:01 -07:00
committed by Facebook Github Bot
parent a810e6875f
commit 9d0b7d8f31
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ReactCommon/cxxreact/BUCK
View File

@@ -141,6 +141,7 @@ rn_xplat_cxx_library(
],
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
fbobjc_deps = APPLE_JSC_DEPS,
fbobjc_force_static = True,
fbobjc_frameworks = [
"$SDKROOT/System/Library/Frameworks/JavaScriptCore.framework",
],

6
ReactCommon/cxxreact/tests/BUCK
View File

@@ -1,4 +1,4 @@
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target")
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "APPLE_JSC_DEPS", "ANDROID_JSC_DEPS")
TEST_SRCS = [
"RecoverableErrorTest.cpp",
@@ -28,7 +28,7 @@ if not IS_OSS_BUILD:
'xplat//third-party/linker_lib:android',
'xplat//third-party/gmock:gtest',
react_native_xplat_target('cxxreact:bridge'),
],
] + ANDROID_JSC_DEPS,
visibility = [
'fbandroid//instrumentation_tests/...'
],
@@ -47,7 +47,7 @@ if not IS_OSS_BUILD:
'xplat//third-party/gmock:gtest',
react_native_xplat_target('cxxreact:bridge'),
react_native_xplat_target('jschelpers:jschelpers'),
],
] + APPLE_JSC_DEPS,
visibility = [
react_native_xplat_target('cxxreact/...'),
],