From 9ac219e0773f1b0bd5ed583d94c910c14ea4e2f4 Mon Sep 17 00:00:00 2001 From: zhongwuzw Date: Mon, 25 Feb 2019 20:31:42 -0800 Subject: [PATCH] fix getter of result from Image query cache (#23602) Summary: We assume `map` is the type of `Map`, but actually it's not, so we would get type error. [iOS] [Fixed] - [RNTester] fix getter of result from Image query cache Pull Request resolved: https://github.com/facebook/react-native/pull/23602 Differential Revision: D14221747 Pulled By: cpojer fbshipit-source-id: 06cf08078a330e4d5731ad72010c87e9e69fcd7b --- Libraries/Image/Image.android.js | 2 +- Libraries/Image/Image.ios.js | 2 +- RNTester/js/ImageExample.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/Image/Image.android.js b/Libraries/Image/Image.android.js index a4269be70..422aeda2d 100644 --- a/Libraries/Image/Image.android.js +++ b/Libraries/Image/Image.android.js @@ -157,7 +157,7 @@ function abortPrefetch(requestId: number) { */ async function queryCache( urls: Array, -): Promise> { +): Promise<{[string]: 'memory' | 'disk' | 'disk/memory'}> { return await ImageLoader.queryCache(urls); } diff --git a/Libraries/Image/Image.ios.js b/Libraries/Image/Image.ios.js index d8ab46169..7fb0462bc 100644 --- a/Libraries/Image/Image.ios.js +++ b/Libraries/Image/Image.ios.js @@ -48,7 +48,7 @@ function prefetch(url: string) { async function queryCache( urls: Array, -): Promise> { +): Promise<{[string]: 'memory' | 'disk' | 'disk/memory'}> { return await ImageViewManager.queryCache(urls); } diff --git a/RNTester/js/ImageExample.js b/RNTester/js/ImageExample.js index 7b55b1c4f..8d2d9f18a 100644 --- a/RNTester/js/ImageExample.js +++ b/RNTester/js/ImageExample.js @@ -93,7 +93,7 @@ class NetworkImageCallbackExample extends React.Component< `✔ Prefetch OK (+${new Date() - mountTime}ms)`, ); Image.queryCache([IMAGE_PREFETCH_URL]).then(map => { - const result = map.get(IMAGE_PREFETCH_URL); + const result = map[IMAGE_PREFETCH_URL]; if (result) { this._loadEventFired( `✔ queryCache "${result}" (+${new Date() -