kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-03 22:48:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix measureInWindow when using Nodes

Browse Source 
Summary:
The results from measureInWindow were always wrong the first time it
was called. This was due to the fact that the view in question was not
actually a view yet, so the results were incorrect. This patch uses the
existing measure functionality (which can measure virtual nodes) to measure
the view, while modifying it to properly get the results relative to the
window instead of relative to the root view.

Reviewed By: sriramramani

Differential Revision: D3501544
This commit is contained in:
Ahmed El-Helw
2016-06-30 17:03:23 -07:00
parent ace1b4d78e
commit 9a28701bd8
2 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java
View File

@@ -182,6 +182,10 @@ public class FlatUIImplementation extends UIImplementation {
@Override
public void measure(int reactTag, Callback callback) {
measureHelper(reactTag, false, callback);
}
private void measureHelper(int reactTag, boolean relativeToWindow, Callback callback) {
FlatShadowNode node = (FlatShadowNode) resolveShadowNode(reactTag);
if (node.mountsToView()) {
mStateBuilder.ensureBackingViewIsCreated(node);
@@ -216,6 +220,7 @@ public class FlatUIImplementation extends UIImplementation {
yInParent / parentHeight,
width / parentWidth,
height / parentHeight,
relativeToWindow,
callback);
}
@@ -235,8 +240,7 @@ public class FlatUIImplementation extends UIImplementation {
@Override
public void measureInWindow(int reactTag, Callback callback) {
ensureMountsToViewAndBackingViewIsCreated(reactTag);
super.measureInWindow(reactTag, callback);
measureHelper(reactTag, true, callback);
}
@Override