From 99d294bf3d2be24cb2950e0785bebd645a660771 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Thu, 19 Oct 2017 17:46:53 -0700 Subject: [PATCH] Consider negative border radii and widths invalid Reviewed By: achen1 Differential Revision: D5998369 fbshipit-source-id: d54302777f4eeb13f4521800130c17ac07f1b354 --- .../com/facebook/react/views/view/ReactViewManager.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java index 0b4de9ad9..0ca79f814 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java @@ -73,6 +73,10 @@ public class ReactViewManager extends ViewGroupManager { defaultFloat = YogaConstants.UNDEFINED ) public void setBorderRadius(ReactViewGroup view, int index, float borderRadius) { + if (!YogaConstants.isUndefined(borderRadius) && borderRadius < 0) { + borderRadius = YogaConstants.UNDEFINED; + } + if (!YogaConstants.isUndefined(borderRadius)) { borderRadius = PixelUtil.toPixelFromDIP(borderRadius); } @@ -153,9 +157,14 @@ public class ReactViewManager extends ViewGroupManager { defaultFloat = YogaConstants.UNDEFINED ) public void setBorderWidth(ReactViewGroup view, int index, float width) { + if (!YogaConstants.isUndefined(width) && width < 0) { + width = YogaConstants.UNDEFINED; + } + if (!YogaConstants.isUndefined(width)) { width = PixelUtil.toPixelFromDIP(width); } + view.setBorderWidth(SPACING_TYPES[index], width); }