From 918620bdcb0d1fef8dc02c6e4a047e5f2287caa6 Mon Sep 17 00:00:00 2001 From: ericlewis Date: Mon, 25 Feb 2019 14:26:21 -0800 Subject: [PATCH] Fix xcode warnings (#23648) Summary: Fixes yet more Xcode warnings. [iOS] [Fixed] - Xcode warnings Pull Request resolved: https://github.com/facebook/react-native/pull/23648 Differential Revision: D14214231 Pulled By: hramos fbshipit-source-id: 050ab8519ca77941894b650b1c56bfcbe86e2c69 --- React/CxxModule/DispatchMessageQueueThread.h | 2 +- React/React.xcodeproj/project.pbxproj | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/React/CxxModule/DispatchMessageQueueThread.h b/React/CxxModule/DispatchMessageQueueThread.h index 5fa1c5caa..bf1cc899b 100644 --- a/React/CxxModule/DispatchMessageQueueThread.h +++ b/React/CxxModule/DispatchMessageQueueThread.h @@ -28,7 +28,7 @@ public: dispatch_async(queue, block); } } - void runOnQueueSync(std::function&& func) override { + void runOnQueueSync(std::function&& __unused func) override { LOG(FATAL) << "Unsupported operation"; } void quitSynchronous() override { diff --git a/React/React.xcodeproj/project.pbxproj b/React/React.xcodeproj/project.pbxproj index ff871363e..d0a7f230a 100644 --- a/React/React.xcodeproj/project.pbxproj +++ b/React/React.xcodeproj/project.pbxproj @@ -4755,6 +4755,7 @@ CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_SUSPICIOUS_MOVES = YES; DEBUG_INFORMATION_FORMAT = dwarf; + GCC_WARN_SHADOW = NO; OTHER_LDFLAGS = "-ObjC"; PRIVATE_HEADERS_FOLDER_PATH = "/usr/local/include/double-conversion"; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -4772,6 +4773,7 @@ CLANG_WARN_SUSPICIOUS_MOVES = YES; COPY_PHASE_STRIP = NO; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; + GCC_WARN_SHADOW = NO; OTHER_LDFLAGS = "-ObjC"; PRIVATE_HEADERS_FOLDER_PATH = "/usr/local/include/double-conversion"; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -4787,7 +4789,7 @@ CLANG_ANALYZER_NONNULL = YES; CLANG_CXX_LANGUAGE_STANDARD = "c++14"; CLANG_WARN_COMMA = NO; - CLANG_WARN_DOCUMENTATION_COMMENTS = YES; + CLANG_WARN_DOCUMENTATION_COMMENTS = NO; CLANG_WARN_SUSPICIOUS_MOVES = YES; DEBUG_INFORMATION_FORMAT = dwarf; HEADER_SEARCH_PATHS = ( @@ -4811,7 +4813,7 @@ CLANG_ANALYZER_NONNULL = YES; CLANG_CXX_LANGUAGE_STANDARD = "c++14"; CLANG_WARN_COMMA = NO; - CLANG_WARN_DOCUMENTATION_COMMENTS = YES; + CLANG_WARN_DOCUMENTATION_COMMENTS = NO; CLANG_WARN_SUSPICIOUS_MOVES = YES; COPY_PHASE_STRIP = NO; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; @@ -4876,7 +4878,7 @@ CLANG_ANALYZER_NONNULL = YES; CLANG_CXX_LANGUAGE_STANDARD = "c++14"; CLANG_WARN_COMMA = NO; - CLANG_WARN_DOCUMENTATION_COMMENTS = YES; + CLANG_WARN_DOCUMENTATION_COMMENTS = NO; CLANG_WARN_SUSPICIOUS_MOVES = YES; DEBUG_INFORMATION_FORMAT = dwarf; HEADER_SEARCH_PATHS = ( @@ -4901,7 +4903,7 @@ CLANG_ANALYZER_NONNULL = YES; CLANG_CXX_LANGUAGE_STANDARD = "c++14"; CLANG_WARN_COMMA = NO; - CLANG_WARN_DOCUMENTATION_COMMENTS = YES; + CLANG_WARN_DOCUMENTATION_COMMENTS = NO; CLANG_WARN_SUSPICIOUS_MOVES = YES; COPY_PHASE_STRIP = NO; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; @@ -4928,6 +4930,7 @@ CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_SUSPICIOUS_MOVES = YES; DEBUG_INFORMATION_FORMAT = dwarf; + GCC_WARN_SHADOW = NO; OTHER_LDFLAGS = "-ObjC"; PRIVATE_HEADERS_FOLDER_PATH = "/usr/local/include/double-conversion"; PRODUCT_NAME = "double-conversion"; @@ -4946,6 +4949,7 @@ CLANG_WARN_SUSPICIOUS_MOVES = YES; COPY_PHASE_STRIP = NO; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; + GCC_WARN_SHADOW = NO; OTHER_LDFLAGS = "-ObjC"; PRIVATE_HEADERS_FOLDER_PATH = "/usr/local/include/double-conversion"; PRODUCT_NAME = "double-conversion";