From 90aa7b951d076a36b07dc3ba702fe79475e60748 Mon Sep 17 00:00:00 2001 From: DengYun Date: Mon, 21 Mar 2016 17:42:55 -0700 Subject: [PATCH] Fix #5599: toast doesn't disappear after app exited. Summary:Run `Toast.makeText` other than UI Thread will cause bug #5599 : toast doesn't disappear after app exited. use `UiThreadUtil.runOnUiThread` to fix this. Closes https://github.com/facebook/react-native/pull/6443 Differential Revision: D3047261 fb-gh-sync-id: 0096879f2a4b4d76bda996a32089f068ae68e3f3 shipit-source-id: 0096879f2a4b4d76bda996a32089f068ae68e3f3 --- .../com/facebook/react/modules/toast/ToastModule.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.java index d401bfa1d..ea6cb471f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/toast/ToastModule.java @@ -17,6 +17,7 @@ import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReactContextBaseJavaModule; import com.facebook.react.bridge.ReactMethod; import com.facebook.react.common.MapBuilder; +import com.facebook.react.bridge.UiThreadUtil; import java.util.Map; @@ -46,7 +47,12 @@ public class ToastModule extends ReactContextBaseJavaModule { } @ReactMethod - public void show(String message, int duration) { - Toast.makeText(getReactApplicationContext(), message, duration).show(); + public void show(final String message, final int duration) { + UiThreadUtil.runOnUiThread(new Runnable() { + @Override + public void run(){ + Toast.makeText(getReactApplicationContext(), message, duration).show(); + } + }); } }