kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-21 08:22:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

macOS : request interactive input when killing the packager (#19663)

Browse Source 
Summary:
Do not request interactive input when running on a CI

When I'm running the build on my CI server, many Terminal windows are remaining on the server because of the `read` command.

This PR prevent this behaviour when the `CI` environment variable is defined so that it doesn't alter the behaviour on local machines.
Pull Request resolved: https://github.com/facebook/react-native/pull/19663

Differential Revision: D14206458

Pulled By: cpojer

fbshipit-source-id: 476067ebebb07c6e708469fa8829a06e05c58200
This commit is contained in:
Guillaume Hain
2019-02-24 22:45:03 -08:00
committed by Facebook Github Bot
parent 5bc9c9b014
commit 8d2e8fdca4
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/launchPackager.command
View File

@@ -13,5 +13,7 @@ THIS_DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOUR
# shellcheck source=/dev/null
. "$THIS_DIR/packager.sh"
echo "Process terminated. Press <enter> to close the window"
read -r
if [[ -z "$CI" ]]; then
echo "Process terminated. Press <enter> to close the window"
read -r
fi