kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-02 14:54:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove DrawImageWithPipeline from Nodes

Browse Source 
Summary:
Nodes historically had two image implementations -
DrawImageWithDrawee and DrawImageWithPipeline. The drawee implementation
was the default (per request of the Fresco team). At this point, there is
no point of having two (especially since updates to one need to be made to
the other), so this patch removes pipeline.

Reviewed By: sriramramani

Differential Revision: D3755523
This commit is contained in:
Ahmed El-Helw
2016-08-31 15:42:25 -07:00
parent 82a4017ecd
commit 8cff05101a
3 changed files with 2 additions and 326 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ReactAndroid/src/main/java/com/facebook/react/flat/RCTImageViewManager.java
View File

@@ -11,8 +11,6 @@ package com.facebook.react.flat;
/* package */ final class RCTImageViewManager extends FlatViewManager {
private static final boolean USE_IMAGEPIPELINE_DIRECTLY = false;
@Override
public String getName() {
return "RCTImageView";
@@ -20,11 +18,7 @@ package com.facebook.react.flat;
@Override
public RCTImageView createShadowNodeInstance() {
if (USE_IMAGEPIPELINE_DIRECTLY) {
return new RCTImageView(new DrawImageWithPipeline());
} else {
return new RCTImageView(new DrawImageWithDrawee());
}
return new RCTImageView(new DrawImageWithDrawee());
}
@Override