From 88139eb6e18ec268b1ba1e4f373992be33b5aae7 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 12 Apr 2018 09:50:55 -0700 Subject: [PATCH] rename unmountComponentAtNodeAndRemoveContainer -> unmountComponentAtNode Reviewed By: achen1 Differential Revision: D7597730 fbshipit-source-id: d72a138b3fc82b09ab7b871089356d38c8405631 --- .../src/main/java/com/facebook/react/ReactInstanceManager.java | 2 +- .../java/com/facebook/react/modules/fabric/ReactFabric.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index d2dbda4dd..250f2091a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -1033,7 +1033,7 @@ public class ReactInstanceManager { UiThreadUtil.assertOnUiThread(); if (rootView.isFabric()) { catalystInstance.getJSModule(ReactFabric.class) - .unmountComponentAtNodeAndRemoveContainer(rootView.getId()); + .unmountComponentAtNode(rootView.getId()); } else { catalystInstance.getJSModule(AppRegistry.class) .unmountApplicationComponentAtRootTag(rootView.getId()); diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/fabric/ReactFabric.java b/ReactAndroid/src/main/java/com/facebook/react/modules/fabric/ReactFabric.java index 888e9bafd..fd0896bdd 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/fabric/ReactFabric.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/fabric/ReactFabric.java @@ -13,6 +13,6 @@ public interface ReactFabric extends JavaScriptModule { * JS method used to unmount Fabric surfaces. * @param rootTag {@link int} react tag of Root {@link com.facebook.react.uimanager.ReactShadowNode} */ - void unmountComponentAtNodeAndRemoveContainer(int rootTag); + void unmountComponentAtNode(int rootTag); }