kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-06-19 19:15:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

test_ios → ✅: Update iOS Snapshots, remove tvOS tests, disable failing tests (#22720)

Browse Source 
Summary:
The following tests are disabled in this PR:

- testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in https://github.com/facebook/react-native/issues/22695
- testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in https://github.com/facebook/react-native/issues/22697

I've added a comment regarding testWebSocketTest and how to ensure it passes locally.

This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent.
Pull Request resolved: https://github.com/facebook/react-native/pull/22720

Differential Revision: D13532788

Pulled By: hramos

fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
This commit is contained in:
Héctor Ramos
2018-12-20 15:04:40 -08:00
committed by Facebook Github Bot
parent a3c6e1da10
commit 86d0611c5a
4 changed files with 30 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/objc-test.sh
View File

@@ -15,7 +15,7 @@
set -ex
SCRIPTS=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
ROOT=$(dirname $SCRIPTS)
ROOT=$(dirname "$SCRIPTS")
cd "$ROOT"