From 855f7be4b86c425324832a51d00c6cf2bcbd977d Mon Sep 17 00:00:00 2001 From: Martin Konicek Date: Wed, 14 Oct 2015 07:46:25 -0700 Subject: [PATCH] Make Android examples depend on source again MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: @​public The idea was to depend on a fixed version from Maven to make running the examples easy, however that only works if we depend on both fixed version of JS and the Android artifacts. The current way leads to version mismatches and causes confusion: https://github.com/facebook/react-native/issues/3329 This commit makes the Android examples consistent with iOS (always build the latest JS and native code from master). Added docs here: https://github.com/facebook/react-native/commit/8abfb5e0e2015a0b8a80cba81ccf249df275adcb Reviewed By: @foghina Differential Revision: D2531525 fb-gh-sync-id: 7c0844b63ddeb94ad008a3f0e7a43e1af69031c4 --- Examples/Movies/android/app/build.gradle | 8 ++------ Examples/UIExplorer/android/app/build.gradle | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/Examples/Movies/android/app/build.gradle b/Examples/Movies/android/app/build.gradle index 57c83e579..6bc71ffda 100644 --- a/Examples/Movies/android/app/build.gradle +++ b/Examples/Movies/android/app/build.gradle @@ -26,10 +26,6 @@ dependencies { compile fileTree(dir: 'libs', include: ['*.jar']) compile 'com.android.support:appcompat-v7:23.0.1' - // Depend on pre-built React Native - compile 'com.facebook.react:react-native:0.11.+' - - // Depend on React Native source. - // This is useful for testing your changes when working on React Native. - // compile project(':ReactAndroid') + // Build React Native from source + compile project(':ReactAndroid') } diff --git a/Examples/UIExplorer/android/app/build.gradle b/Examples/UIExplorer/android/app/build.gradle index 275ffb277..fae695a34 100644 --- a/Examples/UIExplorer/android/app/build.gradle +++ b/Examples/UIExplorer/android/app/build.gradle @@ -26,10 +26,6 @@ dependencies { compile fileTree(dir: 'libs', include: ['*.jar']) compile 'com.android.support:appcompat-v7:23.0.1' - // Depend on pre-built React Native - compile 'com.facebook.react:react-native:0.11.+' - - // Depend on React Native source. - // This is useful for testing your changes when working on React Native. - // compile project(':ReactAndroid') + // Build React Native from source + compile project(':ReactAndroid') }