kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-03-04 22:36:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove compiler warning (#23588)

Browse Source 
Summary:
Fixed compiler warning, after this, seems we have no warning for framework in debug mode.
<img width="1280" alt="image" src="https://user-images.githubusercontent.com/5061845/53224564-2d14e980-36b0-11e9-85f4-46304513b18d.png">

[iOS] [Fixed] - Remove compiler warning
Pull Request resolved: https://github.com/facebook/react-native/pull/23588

Differential Revision: D14181748

Pulled By: cpojer

fbshipit-source-id: 8b633e7cdb7b3b8029f4145a1155e540ac516191
This commit is contained in:
zhongwuzw
2019-02-22 01:37:24 -08:00
committed by Facebook Github Bot
parent 8ce3c1b43e
commit 81860c59c3
9 changed files with 33 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ReactCommon/cxxreact/SampleCxxModule.cpp
View File

@@ -94,13 +94,13 @@ auto SampleCxxModule::getMethods() -> std::vector<Method> {
jsArgAsString(args, 1))});
}),
Method("repeat", [this](dynamic args, Callback cb) {
cb({sample_->repeat(jsArgAsInt(args, 0),
cb({sample_->repeat((int)jsArgAsInt(args, 0),
jsArgAsString(args, 1))});
}),
Method("save", this, &SampleCxxModule::save),
Method("load", this, &SampleCxxModule::load),
Method("call_later", [this](dynamic args, Callback cb) {
sample_->call_later(jsArgAsInt(args, 0), [cb] {
sample_->call_later((int)jsArgAsInt(args, 0), [cb] {
cb({});
});
}),
@@ -145,7 +145,7 @@ void SampleCxxModule::save(folly::dynamic args) {
sample_->save(std::move(m));
}
void SampleCxxModule::load(folly::dynamic args, Callback cb) {
void SampleCxxModule::load(__unused folly::dynamic args, Callback cb) {
dynamic d = dynamic::object;
for (const auto& p : sample_->load()) {
d.insert(p.first, p.second);