kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-06-17 07:59:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove compiler warning (#23588)

Browse Source 
Summary:
Fixed compiler warning, after this, seems we have no warning for framework in debug mode.
<img width="1280" alt="image" src="https://user-images.githubusercontent.com/5061845/53224564-2d14e980-36b0-11e9-85f4-46304513b18d.png">

[iOS] [Fixed] - Remove compiler warning
Pull Request resolved: https://github.com/facebook/react-native/pull/23588

Differential Revision: D14181748

Pulled By: cpojer

fbshipit-source-id: 8b633e7cdb7b3b8029f4145a1155e540ac516191
This commit is contained in:
zhongwuzw
2019-02-22 01:37:24 -08:00
committed by Facebook Github Bot
parent 8ce3c1b43e
commit 81860c59c3
9 changed files with 33 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ReactCommon/cxxreact/NativeToJsBridge.cpp
View File

@@ -43,7 +43,7 @@ public:
}
void callNativeModules(
JSExecutor& executor, folly::dynamic&& calls, bool isEndOfBatch) override {
__unused JSExecutor& executor, folly::dynamic&& calls, bool isEndOfBatch) override {
CHECK(m_registry || calls.empty()) <<
"native module calls cannot be completed with no native modules";
@@ -68,7 +68,7 @@ public:
}
MethodCallResult callSerializableNativeHook(
JSExecutor& executor, unsigned int moduleId, unsigned int methodId,
__unused JSExecutor& executor, unsigned int moduleId, unsigned int methodId,
folly::dynamic&& args) override {
return m_registry->callSerializableNativeHook(moduleId, methodId, std::move(args));
}