From 811090952643bcb9b78320d56c248a578dccb36f Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sat, 2 Feb 2019 11:55:19 -0800 Subject: [PATCH] Add QPL marker to track time it takes to load .so file from RN Summary: Simple diff that adds QPL marker to track time it takes to load .so file used by RN Fabric Reviewed By: fkgozali Differential Revision: D13934149 fbshipit-source-id: a5cb0fc255394cf6c936b9018c753dcc774c347f --- .../java/com/facebook/react/bridge/ReactMarkerConstants.java | 2 ++ .../java/com/facebook/react/fabric/jsi/FabricSoLoader.java | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java index 4ba2791aa..b82928288 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java @@ -94,4 +94,6 @@ public enum ReactMarkerConstants { JAVASCRIPT_EXECUTOR_FACTORY_INJECT_END, LOAD_REACT_NATIVE_SO_FILE_START, LOAD_REACT_NATIVE_SO_FILE_END, + LOAD_REACT_NATIVE_FABRIC_SO_FILE_START, + LOAD_REACT_NATIVE_FABRIC_SO_FILE_END, } diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/FabricSoLoader.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/FabricSoLoader.java index 7bc4c100c..f84a2ac83 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/FabricSoLoader.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/FabricSoLoader.java @@ -8,6 +8,8 @@ package com.facebook.react.fabric.jsi; import static com.facebook.systrace.Systrace.TRACE_TAG_REACT_JAVA_BRIDGE; +import com.facebook.react.bridge.ReactMarker; +import com.facebook.react.bridge.ReactMarkerConstants; import com.facebook.soloader.SoLoader; import com.facebook.systrace.Systrace; @@ -22,7 +24,9 @@ public class FabricSoLoader { Systrace.beginSection( Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricSoLoader.staticInit::load:fabricjni"); + ReactMarker.logMarker(ReactMarkerConstants.LOAD_REACT_NATIVE_SO_FILE_START); SoLoader.loadLibrary("fabricjni"); + ReactMarker.logMarker(ReactMarkerConstants.LOAD_REACT_NATIVE_SO_FILE_END); Systrace.endSection(TRACE_TAG_REACT_JAVA_BRIDGE); } }