From 7f6d4351883201199ce9af94de25e32a7f11820a Mon Sep 17 00:00:00 2001 From: Liam Date: Mon, 14 Nov 2016 20:55:56 -0800 Subject: [PATCH] "this" not needed in mReactInstanceManager.onDestroy() Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see Closes https://github.com/facebook/react-native/pull/10924 Differential Revision: D4181397 Pulled By: ericvicenti fbshipit-source-id: e5c762937efba3bd65fbe00cc94678e8c1461659 --- docs/IntegrationWithExistingApps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/IntegrationWithExistingApps.md b/docs/IntegrationWithExistingApps.md index 848e3972c..2a3e90c97 100644 --- a/docs/IntegrationWithExistingApps.md +++ b/docs/IntegrationWithExistingApps.md @@ -693,7 +693,7 @@ protected void onDestroy() { super.onDestroy(); if (mReactInstanceManager != null) { - mReactInstanceManager.onDestroy(this); + mReactInstanceManager.onDestroy(); } } ```