kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-03 07:14:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove 'Debug JS on-device (experimental)' feature

Browse Source 
Reviewed By: bnham

Differential Revision: D5706200

fbshipit-source-id: f389222a9266819c5730860a2e3e461eb1068d0e
This commit is contained in:
Nurzhan Bakibayev
2017-08-29 04:21:04 -07:00
committed by Facebook Github Bot
parent 7542f3d659
commit 7d0c128174
6 changed files with 0 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java
View File

@@ -201,12 +201,6 @@ public class DevServerHelper {
}.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
}
public void openInspector(String id) {
if (mInspectorPackagerConnection != null) {
mInspectorPackagerConnection.sendOpenEvent(id);
}
}
public void sendEventToAllConnections(String event) {
if (mInspectorPackagerConnection != null) {
mInspectorPackagerConnection.sendEventToAllConnections(event);

14
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java
View File

@@ -44,7 +44,6 @@ import com.facebook.infer.annotation.Assertions;
import com.facebook.react.R;
import com.facebook.react.bridge.CatalystInstance;
import com.facebook.react.bridge.DefaultNativeModuleCallExceptionHandler;
import com.facebook.react.bridge.Inspector;
import com.facebook.react.bridge.JavaJSExecutor;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReadableArray;
@@ -385,19 +384,6 @@ public class DevSupportManagerImpl implements
handleReloadJS();
}
});
if (Inspector.isSupported()) {
options.put(
"Debug JS on-device (experimental)", new DevOptionHandler() {
@Override
public void onOptionSelected() {
List<Inspector.Page> pages = Inspector.getPages();
if (pages.size() > 0) {
// TODO: We should get the actual page id instead of the first one.
mDevServerHelper.openInspector(String.valueOf(pages.get(0).getId()));
}
}
});
}
options.put(
mDevSettings.isReloadOnJSChangeEnabled()
? mApplicationContext.getString(R.string.catalyst_live_reload_off)

9
ReactAndroid/src/main/java/com/facebook/react/devsupport/InspectorPackagerConnection.java
View File

@@ -56,15 +56,6 @@ public class InspectorPackagerConnection {
}
}
public void sendOpenEvent(String pageId) {
try {
JSONObject payload = makePageIdPayload(pageId);
sendEvent("open", payload);
} catch (JSONException e) {
FLog.e(TAG, "Failed to open page", e);
}
}
void handleProxyMessage(JSONObject message)
throws JSONException, IOException {
String event = message.getString("event");