kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-28 12:15:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Surfacing Flow issues around invalid props

Browse Source 
Reviewed By: yungsters

Differential Revision: D7977386

fbshipit-source-id: a6df2d75e0caa55a84f9c9c6860f622942955dfc
This commit is contained in:
Eli White
2018-05-12 10:25:05 -07:00
committed by Facebook Github Bot
parent 65c336f38f
commit 7ba7acdee7
5 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/Components/ScrollView/ScrollView.js
View File

@@ -237,6 +237,7 @@ const ScrollView = createReactClass({
* - `false`, deprecated, use 'never' instead * - `false`, deprecated, use 'never' instead
* - `true`, deprecated, use 'always' instead * - `true`, deprecated, use 'always' instead
*/ */
// $FlowFixMe
keyboardShouldPersistTaps: PropTypes.oneOf([ keyboardShouldPersistTaps: PropTypes.oneOf([
'always', 'always',
'never', 'never',
@@ -521,9 +522,11 @@ const ScrollView = createReactClass({
UNSAFE_componentWillMount: function() { UNSAFE_componentWillMount: function() {
this._scrollAnimatedValue = new AnimatedImplementation.Value( this._scrollAnimatedValue = new AnimatedImplementation.Value(
// $FlowFixMe
this.props.contentOffset ? this.props.contentOffset.y : 0, this.props.contentOffset ? this.props.contentOffset.y : 0,
); );
this._scrollAnimatedValue.setOffset( this._scrollAnimatedValue.setOffset(
// $FlowFixMe
this.props.contentInset ? this.props.contentInset.top : 0, this.props.contentInset ? this.props.contentInset.top : 0,
); );
this._stickyHeaderRefs = new Map(); this._stickyHeaderRefs = new Map();

2
Libraries/Lists/MetroListView.js
View File

@@ -146,7 +146,7 @@ class MetroListView extends React.Component<Props, $FlowFixMeState> {
/> />
); );
} }
_listRef: ListView; _listRef: ?ListView;
_captureRef = ref => { _captureRef = ref => {
this._listRef = ref; this._listRef = ref;
}; };

6
Libraries/StyleSheet/EdgeInsetsPropType.js
View File

@@ -12,14 +12,12 @@
const PropTypes = require('prop-types'); const PropTypes = require('prop-types');
const createStrictShapeTypeChecker = require('createStrictShapeTypeChecker'); const EdgeInsetsPropType = PropTypes.shape({
const EdgeInsetsPropType = (createStrictShapeTypeChecker({
top: PropTypes.number, top: PropTypes.number,
left: PropTypes.number, left: PropTypes.number,
bottom: PropTypes.number, bottom: PropTypes.number,
right: PropTypes.number, right: PropTypes.number,
}): ReactPropsCheckType & ReactPropsChainableTypeChecker); });
export type EdgeInsetsProp = {| export type EdgeInsetsProp = {|
+top: number, +top: number,

4
Libraries/StyleSheet/PointPropType.js
View File

@@ -12,9 +12,7 @@
const PropTypes = require('prop-types'); const PropTypes = require('prop-types');
const createStrictShapeTypeChecker = require('createStrictShapeTypeChecker'); const PointPropType = PropTypes.shape({
const PointPropType = createStrictShapeTypeChecker({
x: PropTypes.number, x: PropTypes.number,
y: PropTypes.number, y: PropTypes.number,
}); });

2
RNTester/js/ScrollViewExample.js
View File

@@ -80,7 +80,7 @@ exports.examples = [
title: string, title: string,
additionalStyles: typeof StyleSheet, additionalStyles: typeof StyleSheet,
) { ) {
let _scrollView: ScrollView; let _scrollView: ?ScrollView;
return ( return (
<View style={additionalStyles}> <View style={additionalStyles}>
<Text style={styles.text}>{title}</Text> <Text style={styles.text}>{title}</Text>