From 7236788f345e0e1d063b90bc6db86e268fddb542 Mon Sep 17 00:00:00 2001 From: rocman Date: Mon, 2 Nov 2015 10:06:42 -0800 Subject: [PATCH] Memory Leaks caused by RCTNavigator Summary: releasing the viewControllers referred by _navigationController.viewControllers, which is also releasing the related views Closes https://github.com/facebook/react-native/pull/3808 Reviewed By: svcscm Differential Revision: D2604735 Pulled By: javache fb-gh-sync-id: f202d155f04169f3f0f0ef26365b37b8525b6687 --- React/Views/RCTNavigator.m | 1 + 1 file changed, 1 insertion(+) diff --git a/React/Views/RCTNavigator.m b/React/Views/RCTNavigator.m index 2ff678eed..907eda4a9 100644 --- a/React/Views/RCTNavigator.m +++ b/React/Views/RCTNavigator.m @@ -335,6 +335,7 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)aDecoder) - (void)dealloc { _navigationController.delegate = nil; + [_navigationController removeFromParentViewController]; } - (UIViewController *)reactViewController