From 6ddcef8a2349a378e05172672528e2facd98c439 Mon Sep 17 00:00:00 2001 From: Elliot Hesp Date: Wed, 16 Dec 2015 05:16:15 -0800 Subject: [PATCH] Update to PullToRefreshViewAndroid docs Summary: As mentioned in https://github.com/facebook/react-native/issues/4793 it is not initially clear that the PullToRefreshViewAndroid component needs the `{flex: 1}` style in order for it's child component to function correctly (without examining the example). This will hopefully clear that up. Closes https://github.com/facebook/react-native/pull/4814 Reviewed By: svcscm Differential Revision: D2764534 Pulled By: androidtrunkagent fb-gh-sync-id: ae1c529342e85f8348b4f683e42bf25df5dbea09 --- Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js b/Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js index 41acc8017..68d6de95d 100644 --- a/Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js +++ b/Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js @@ -23,6 +23,9 @@ var NATIVE_REF = 'native_swiperefreshlayout'; /** * React view that supports a single scrollable child view (e.g. `ScrollView`). When this child * view is at `scrollY: 0`, swiping down triggers an `onRefresh` event. + * + * The style `{flex: 1}` might be required to ensure the expected behavior of the child component + * (e.g. when the child is expected to scroll with `ScrollView` or `ListView`). */ var PullToRefreshViewAndroid = React.createClass({ statics: {