kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-13 17:26:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update ViewGroupManager interface to use index for remove method.

Browse Source 
Differential Revision: D2610700

fb-gh-sync-id: b59dfc581d9ca8d29203b5915fb743f3270989ab
This commit is contained in:
Krzysztof Magiera
2015-11-03 08:54:12 -08:00
committed by facebook-github-bot-5
parent e63fb0e8c9
commit 6c204dcbea
7 changed files with 56 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java
View File

@@ -310,19 +310,7 @@ import com.facebook.react.touch.JSResponderHandler;
viewsToAdd,
tagsToDelete));
}
View childView = viewManager.getChildAt(viewToManage, indicesToRemove[i]);
if (childView == null) {
throw new IllegalViewOperationException(
"Trying to remove a null view at index:"
+ indexToRemove + " view tag: " + tag + "\n detail: " +
constructManageChildrenErrorMessage(
viewToManage,
viewManager,
indicesToRemove,
viewsToAdd,
tagsToDelete));
}
viewManager.removeView(viewToManage, childView);
viewManager.removeViewAt(viewToManage, indicesToRemove[i]);
lastIndexToRemove = indexToRemove;
}
}