kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-07 22:40:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Warm text cache.

Browse Source 
Summary:
Testing impact of warming text, which shows big wins for other teams, notably Instagram.

https://our.intern.facebook.com/intern/dex/comments-rendering-in-instagram-android/

Reviewed By: ahmedre

Differential Revision: D3603846
This commit is contained in:
Seth Kirby
2016-07-22 12:51:40 -07:00
committed by Ahmed El-Helw
parent da8ec6fee6
commit 690368fc3f
1 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java
View File

@@ -25,6 +25,7 @@ import com.facebook.react.uimanager.PixelUtil;
import com.facebook.react.uimanager.ViewDefaults;
import com.facebook.react.uimanager.ViewProps;
import com.facebook.react.uimanager.annotations.ReactProp;
import com.facebook.textcachewarmer.DefaultTextLayoutCacheWarmer;
/**
* RCTText is a top-level node for text. It extends {@link RCTVirtualText} because it can contain
@@ -35,8 +36,13 @@ import com.facebook.react.uimanager.annotations.ReactProp;
*/
/* package */ final class RCTText extends RCTVirtualText implements CSSNode.MeasureFunction {
// We set every value we use every time we use the layout builder, so we can get away with only
// using a single instance.
private static final TextLayoutBuilder sTextLayoutBuilder =
new TextLayoutBuilder().setShouldCacheLayout(false);
new TextLayoutBuilder()
.setShouldCacheLayout(false)
.setShouldWarmText(true)
.setCacheWarmer(new DefaultTextLayoutCacheWarmer());
private @Nullable CharSequence mText;
private @Nullable DrawTextLayout mDrawCommand;
@@ -275,8 +281,6 @@ import com.facebook.react.uimanager.annotations.ReactProp;
Layout.Alignment textAlignment) {
Layout newLayout;
TextLayoutBuilder layoutBuilder = sTextLayoutBuilder;
final @TextLayoutBuilder.MeasureMode int textMeasureMode;
switch (widthMode) {
case UNDEFINED:
@@ -292,7 +296,7 @@ import com.facebook.react.uimanager.annotations.ReactProp;
throw new IllegalStateException("Unexpected size mode: " + widthMode);
}
layoutBuilder
sTextLayoutBuilder
.setEllipsize(ellipsize)
.setMaxLines(maxLines)
.setSingleLine(isSingleLine)
@@ -300,17 +304,17 @@ import com.facebook.react.uimanager.annotations.ReactProp;
.setTextSize(textSize)
.setWidth(width, textMeasureMode);
layoutBuilder.setTextStyle(textStyle);
sTextLayoutBuilder.setTextStyle(textStyle);
layoutBuilder.textDirection(TextDirectionHeuristicsCompat.FIRSTSTRONG_LTR);
layoutBuilder.setIncludeFontPadding(shouldIncludeFontPadding);
layoutBuilder.setTextSpacingExtra(extraSpacing);
layoutBuilder.setTextSpacingMultiplier(spacingMultiplier);
layoutBuilder.setAlignment(textAlignment);
sTextLayoutBuilder.textDirection(TextDirectionHeuristicsCompat.FIRSTSTRONG_LTR);
sTextLayoutBuilder.setIncludeFontPadding(shouldIncludeFontPadding);
sTextLayoutBuilder.setTextSpacingExtra(extraSpacing);
sTextLayoutBuilder.setTextSpacingMultiplier(spacingMultiplier);
sTextLayoutBuilder.setAlignment(textAlignment);
newLayout = layoutBuilder.build();
newLayout = sTextLayoutBuilder.build();
layoutBuilder.setText(null);
sTextLayoutBuilder.setText(null);
return newLayout;
}