kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-01 14:25:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Convert remaining viewmanager to @ReactProp.

Browse Source 
Differential Revision: D2481816

committer: Service User <svcscm@fb.com>
This commit is contained in:
Krzysztof Magiera
2015-09-25 14:43:28 -07:00
committed by facebook-github-bot-7
parent 0fb3d8de83
commit 656126a2f1
12 changed files with 345 additions and 408 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewManager.java
View File

@@ -15,9 +15,8 @@ import java.util.Map;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.common.MapBuilder;
import com.facebook.react.uimanager.CatalystStylesDiffMap;
import com.facebook.react.uimanager.ReactProp;
import com.facebook.react.uimanager.ThemedReactContext;
import com.facebook.react.uimanager.UIProp;
import com.facebook.react.uimanager.ViewGroupManager;
import com.facebook.react.views.view.ReactClippingViewGroupHelper;
@@ -33,11 +32,6 @@ public class ReactScrollViewManager
private static final String REACT_CLASS = "RCTScrollView";
@UIProp(UIProp.Type.BOOLEAN) public static final String PROP_SHOWS_VERTICAL_SCROLL_INDICATOR =
"showsVerticalScrollIndicator";
@UIProp(UIProp.Type.BOOLEAN) public static final String PROP_SHOWS_HORIZONTAL_SCROLL_INDICATOR =
"showsHorizontalScrollIndicator";
@Override
public String getName() {
return REACT_CLASS;
@@ -48,20 +42,19 @@ public class ReactScrollViewManager
return new ReactScrollView(context);
}
@Override
public void updateView(ReactScrollView scrollView, CatalystStylesDiffMap props) {
super.updateView(scrollView, props);
if (props.hasKey(PROP_SHOWS_VERTICAL_SCROLL_INDICATOR)) {
scrollView.setVerticalScrollBarEnabled(
props.getBoolean(PROP_SHOWS_VERTICAL_SCROLL_INDICATOR, true));
}
@ReactProp(name = "showsVerticalScrollIndicator")
public void setShowsVerticalScrollIndicator(ReactScrollView view, boolean value) {
view.setVerticalScrollBarEnabled(value);
}
if (props.hasKey(PROP_SHOWS_HORIZONTAL_SCROLL_INDICATOR)) {
scrollView.setHorizontalScrollBarEnabled(
props.getBoolean(PROP_SHOWS_HORIZONTAL_SCROLL_INDICATOR, true));
}
@ReactProp(name = "showsHorizontalScrollIndicator")
public void setShowsHorizontalScrollIndicator(ReactScrollView view, boolean value) {
view.setHorizontalScrollBarEnabled(value);
}
ReactClippingViewGroupHelper.applyRemoveClippedSubviewsProperty(scrollView, props);
@ReactProp(name = ReactClippingViewGroupHelper.PROP_REMOVE_CLIPPED_SUBVIEWS)
public void setRemoveClippedSubviews(ReactScrollView view, boolean removeClippedSubviews) {
view.setRemoveClippedSubviews(removeClippedSubviews);
}
@Override