From 63fa621df100df05fbdaf04e93304a7d1dc35f92 Mon Sep 17 00:00:00 2001 From: "Andrew Y. Chen" Date: Thu, 16 Mar 2017 16:26:02 -0700 Subject: [PATCH] Fix FrescoModule not initialized in Nodes Reviewed By: AaaChiuuu Differential Revision: D4687127 fbshipit-source-id: d387ff665374bd4ef40fc2e9c19543f2bacf4a66 --- ReactAndroid/src/main/java/com/facebook/react/flat/BUCK | 1 + .../main/java/com/facebook/react/flat/FlatUIImplementation.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/BUCK b/ReactAndroid/src/main/java/com/facebook/react/flat/BUCK index 0354f255e..ed641a76e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/BUCK @@ -19,6 +19,7 @@ android_library( react_native_dep("third-party/java/jsr-305:jsr-305"), react_native_target("java/com/facebook/react/bridge:bridge"), react_native_target("java/com/facebook/react/common:common"), + react_native_target("java/com/facebook/react/modules/fresco:fresco"), react_native_target("java/com/facebook/react/modules/i18nmanager:i18nmanager"), react_native_target("java/com/facebook/react/touch:touch"), react_native_target("java/com/facebook/react/uimanager:uimanager"), diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java index 755b43e64..add945cbb 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java @@ -18,6 +18,7 @@ import com.facebook.infer.annotation.Assertions; import com.facebook.react.bridge.Callback; import com.facebook.react.bridge.ReactApplicationContext; import com.facebook.react.bridge.ReadableArray; +import com.facebook.react.modules.fresco.FrescoModule; import com.facebook.react.modules.i18nmanager.I18nUtil; import com.facebook.react.uimanager.ReactShadowNode; import com.facebook.react.uimanager.ReactStylesDiffMap; @@ -98,6 +99,7 @@ public class FlatUIImplementation extends UIImplementation { // initialization is undefined, and this is pretty much the earliest when we are guarantied // that Fresco is initalized and DraweeControllerBuilder can be queried. This also happens // relatively rarely to have any performance considerations. + mReactContext.getNativeModule(FrescoModule.class); // initialize Fresco DraweeRequestHelper.setDraweeControllerBuilder( mRCTImageViewManager.getDraweeControllerBuilder()); mRCTImageViewManager = null;