kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-08 22:42:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly make UIManagerModule use OnBatchComplete on Android

Browse Source 
Summary:
Currently, we scan all native modules to see if they implement the OnBatchCompleteListerner. If they do, we add those modules to a list, and when C++ calls OnBactchComplete is called, we execute the callback on each of the modules.
The only native module implementing this callback today is the UIManagerModule. With Fabric, UIManager will also not be a native module anymore. This diff removes all the work done for creating the list and assumes that UIManagerModule is the only place that is interested in OnBatchComplete call - and calls it directly.

Reviewed By: achen1

Differential Revision: D9186651

fbshipit-source-id: 473586b37c2465ccd041985dcdd56132026f34f1
This commit is contained in:
Ram N
2018-08-08 14:03:14 -07:00
committed by Facebook Github Bot
parent 69912495f9
commit 617e25d9b5
5 changed files with 13 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ReactAndroid/src/main/java/com/facebook/react/bridge/ModuleHolder.java
View File

@@ -41,7 +41,6 @@ public class ModuleHolder {
private final boolean mCanOverrideExistingModule;
private final boolean mHasConstants;
private final boolean mIsCxxModule;
private final boolean mHasOnBatchCompleteListener;
private @Nullable Provider<? extends NativeModule> mProvider;
// Outside of the constructur, these should only be checked or set when synchronized on this
@@ -57,7 +56,6 @@ public class ModuleHolder {
mCanOverrideExistingModule = moduleInfo.canOverrideExistingModule();
mHasConstants = moduleInfo.hasConstants();
mProvider = provider;
mHasOnBatchCompleteListener = moduleInfo.hasOnBatchCompleteListener();
mIsCxxModule = moduleInfo.isCxxModule();
if (moduleInfo.needsEagerInit()) {
mModule = create();
@@ -69,7 +67,6 @@ public class ModuleHolder {
mCanOverrideExistingModule = nativeModule.canOverrideExistingModule();
mHasConstants = true;
mIsCxxModule = CxxModuleWrapper.class.isAssignableFrom(nativeModule.getClass());
mHasOnBatchCompleteListener = OnBatchCompleteListener.class.isAssignableFrom(nativeModule.getClass());
mModule = nativeModule;
PrinterHolder.getPrinter()
.logMessage(ReactDebugOverlayTags.NATIVE_MODULE, "NativeModule init: %s", mName);
@@ -121,8 +118,6 @@ public class ModuleHolder {
public boolean isCxxModule() {return mIsCxxModule; }
public boolean hasOnBatchCompleteListener() {return mHasOnBatchCompleteListener; }
@DoNotStrip
public NativeModule getModule() {
NativeModule module;