From 60ff2799a1054265af9e6afeba01e373a85a768e Mon Sep 17 00:00:00 2001 From: Taras Tsugrii Date: Wed, 19 Dec 2018 10:47:57 -0800 Subject: [PATCH] Fix Skylint warnings in rn_defs.bzl. Summary: Instead of ignoring the linter, it's better to fix the warnings :) Differential Revision: D13512033 fbshipit-source-id: a3db1417ddfde2e05a0c03c204f3627cc15c5a2d --- tools/build_defs/oss/rn_defs.bzl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/build_defs/oss/rn_defs.bzl b/tools/build_defs/oss/rn_defs.bzl index 359537c01..d2cf1fc45 100644 --- a/tools/build_defs/oss/rn_defs.bzl +++ b/tools/build_defs/oss/rn_defs.bzl @@ -9,7 +9,7 @@ This lets us build React Native: - At Facebook by running buck from the root of the fb repo - Outside of Facebook by running buck in the root of the git repo """ -# @lint-ignore-every SKYLINT BUCKRESTRICTEDSYNTAX +# @lint-ignore-every BUCKRESTRICTEDSYNTAX _DEBUG_PREPROCESSOR_FLAGS = [] @@ -182,6 +182,7 @@ def rn_robolectric_test(name, srcs, vm_args = None, *args, **kwargs): ) def cxx_library(allow_jni_merging = None, **kwargs): + _ignore = allow_jni_merging args = { k: v for k, v in kwargs.items() @@ -273,10 +274,10 @@ def _single_subdir_glob(dirpath, glob_pattern, exclude = None, prefix = None): def oss_cxx_library(**kwargs): cxx_library(**kwargs) -def jni_instrumentation_test_lib(**kwargs): +def jni_instrumentation_test_lib(**_kwargs): """A noop stub for OSS build.""" pass -def fb_xplat_cxx_test(**kwargs): +def fb_xplat_cxx_test(**_kwargs): """A noop stub for OSS build.""" pass