From 5d6e73d0eb62b6c8823b476d84b2881cfb03c5fe Mon Sep 17 00:00:00 2001 From: Ahmed El-Helw Date: Mon, 11 Apr 2016 11:48:39 -0700 Subject: [PATCH] Don't mount nodes to Views on click Summary: Initially, we used to mount nodes to Views anytime a node was clicked. This was not useful, since we could still not handle touch when a touch event was already dispatched. Later, a fix was pushed that supported handling touch events for non-View NodeRegions. Part of the intention was to remove this code, but it was forgotten. Reviewed By: sriramramani Differential Revision: D3160532 --- .../java/com/facebook/react/flat/FlatUIImplementation.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java index 1ef816ec1..c380189a4 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java @@ -453,13 +453,9 @@ public class FlatUIImplementation extends UIImplementation { node = node.getParent(); } - FlatShadowNode nonVirtualNode = (FlatShadowNode) node; - nonVirtualNode.forceMountToView(); - mStateBuilder.ensureBackingViewIsCreated(nonVirtualNode); - FlatUIViewOperationQueue operationsQueue = mStateBuilder.getOperationsQueue(); operationsQueue.enqueueSetJSResponder( - nonVirtualNode.getReactTag(), + node.getReactTag(), possiblyVirtualReactTag, blockNativeResponder); }