kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-02 06:45:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename module name to module path

Browse Source 
Reviewed By: javache

Differential Revision: D5592950

fbshipit-source-id: 7e32043ba6d1de129a4f8dc694bb5987393b0ebc
This commit is contained in:
Kathy Gray
2017-08-10 09:14:49 -07:00
committed by Facebook Github Bot
parent 9b30f56693
commit 5d4c6e5f23
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java
View File

@@ -27,7 +27,7 @@ public class ReactInstanceManagerBuilder {
private @Nullable String mJSBundleAssetUrl;
private @Nullable JSBundleLoader mJSBundleLoader;
private @Nullable String mJSMainModuleName;
private @Nullable String mJSMainModulePath;
private @Nullable NotThreadSafeBridgeIdleDebugListener mBridgeIdleDebugListener;
private @Nullable Application mApplication;
private boolean mUseDeveloperSupport;
@@ -103,8 +103,8 @@ public class ReactInstanceManagerBuilder {
* {@code "index.android"} or
* {@code "subdirectory/index.android"}
*/
public ReactInstanceManagerBuilder setJSMainModuleName(String jsMainModuleName) {
mJSMainModuleName = jsMainModuleName;
public ReactInstanceManagerBuilder setJSMainModulePath(String jsMainModulePath) {
mJSMainModulePath = jsMainModulePath;
return this;
}
@@ -236,8 +236,8 @@ public class ReactInstanceManagerBuilder {
"JS Bundle File or Asset URL has to be provided when dev support is disabled");
Assertions.assertCondition(
mJSMainModuleName != null || mJSBundleAssetUrl != null || mJSBundleLoader != null,
"Either MainModuleName or JS Bundle File needs to be provided");
mJSMainModulePath != null || mJSBundleAssetUrl != null || mJSBundleLoader != null,
"Either MainModulePath or JS Bundle File needs to be provided");
if (mUIImplementationProvider == null) {
// create default UIImplementationProvider if the provided one is null.
@@ -251,7 +251,7 @@ public class ReactInstanceManagerBuilder {
(mJSBundleLoader == null && mJSBundleAssetUrl != null) ?
JSBundleLoader.createAssetLoader(mApplication, mJSBundleAssetUrl, false /*Asynchronous*/) :
mJSBundleLoader,
mJSMainModuleName,
mJSMainModulePath,
mPackages,
mUseDeveloperSupport,
mBridgeIdleDebugListener,