From 5be17c01a113d1342f75ad45b8778479579f839f Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sun, 25 Nov 2018 17:18:12 -0800 Subject: [PATCH] Fix re-measure of text Summary: This diff fixes re-measures of a text component result of a change of state. For details of the bug see: T36838266 Reviewed By: shergin Differential Revision: D13188601 fbshipit-source-id: ea9a889540f600d4e4e788105d5fa22e6cd5448c --- .../com/facebook/react/views/text/TextLayoutManager.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java index 56a34910d..8fca7688e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java @@ -204,16 +204,12 @@ public class TextLayoutManager { TextPaint textPaint = sTextPaintInstance; Layout layout; - Spannable preparedSpannableText = view == null ? null : view.getSpanned(); + Spannable preparedSpannableText = spannedFromTextFragments(context, attributedString.getArray("fragments"), attributedString.getString("string")); // TODO add these props to paragraph attributes int textBreakStrategy = Layout.BREAK_STRATEGY_HIGH_QUALITY; boolean includeFontPadding = true; - if (preparedSpannableText == null) { - preparedSpannableText = spannedFromTextFragments(context, attributedString.getArray("fragments"), attributedString.getString("string")); - } - if (preparedSpannableText == null) { throw new IllegalStateException("Spannable element has not been prepared in onBeforeLayout"); }