kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-10 22:45:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Split JavaSJExecutor and ProxyExecutorException into their own file

Browse Source 
Summary: This makes the exception a nested class of the interface,
which eliminates the dependency of DevSupportManager on
ProxyJavaScriptExecutor.
public

Reviewed By: astreet

Differential Revision: D2651252

fb-gh-sync-id: 99de1c308b9bce717ab749c4e239d2773a920e1f
This commit is contained in:
Marc Horowitz
2015-11-20 12:16:19 -08:00
committed by facebook-github-bot-6
parent 67209e6396
commit 5b6b5a64d1
8 changed files with 69 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
View File

@@ -28,6 +28,7 @@ import com.facebook.react.bridge.Arguments;
import com.facebook.react.bridge.CatalystInstance;
import com.facebook.react.bridge.JSBundleLoader;
import com.facebook.react.bridge.JSCJavaScriptExecutor;
import com.facebook.react.bridge.JavaJSExecutor;
import com.facebook.react.bridge.JavaScriptExecutor;
import com.facebook.react.bridge.JavaScriptModule;
import com.facebook.react.bridge.JavaScriptModulesConfig;
@@ -97,8 +98,8 @@ public class ReactInstanceManager {
new ReactInstanceDevCommandsHandler() {
@Override
public void onReloadWithJSDebugger(ProxyJavaScriptExecutor proxyExecutor) {
ReactInstanceManager.this.onReloadWithJSDebugger(proxyExecutor);
public void onReloadWithJSDebugger(JavaJSExecutor jsExecutor) {
ReactInstanceManager.this.onReloadWithJSDebugger(jsExecutor);
}
@Override
@@ -474,9 +475,9 @@ public class ReactInstanceManager {
return mCurrentReactContext;
}
private void onReloadWithJSDebugger(ProxyJavaScriptExecutor proxyExecutor) {
private void onReloadWithJSDebugger(JavaJSExecutor jsExecutor) {
recreateReactContextInBackground(
proxyExecutor,
new ProxyJavaScriptExecutor(jsExecutor),
JSBundleLoader.createRemoteDebuggerBundleLoader(
mDevSupportManager.getJSBundleURLForRemoteDebugging()));
}