From 596109fa0a5d078f59852dea2e174ac55cc96f93 Mon Sep 17 00:00:00 2001 From: Satvik Jagannath Date: Wed, 30 Dec 2015 14:49:13 -0800 Subject: [PATCH] Fix THUMBNAILS to follow the require Syntax Summary: The THUMB_URLS is following the older syntax. Fixed THUMBNAILS to follows require Syntax. And now you see the thumbnails appearing in the Sample app. Closes https://github.com/facebook/react-native/pull/4995 Reviewed By: svcscm Differential Revision: D2796019 Pulled By: nicklockwood fb-gh-sync-id: c7be50d4dea73fc383db1c6b5a6afa7444505889 --- .../UIExplorer/ListViewGridLayoutExample.js | 28 ++++++++-------- Examples/UIExplorer/ListViewPagingExample.js | 32 +++++++++---------- 2 files changed, 29 insertions(+), 31 deletions(-) diff --git a/Examples/UIExplorer/ListViewGridLayoutExample.js b/Examples/UIExplorer/ListViewGridLayoutExample.js index 6af00aa8a..ac7d56b86 100644 --- a/Examples/UIExplorer/ListViewGridLayoutExample.js +++ b/Examples/UIExplorer/ListViewGridLayoutExample.js @@ -26,18 +26,18 @@ var { } = React; var THUMB_URLS = [ - 'Thumbnails/like.png', - 'Thumbnails/dislike.png', - 'Thumbnails/call.png', - 'Thumbnails/fist.png', - 'Thumbnails/bandaged.png', - 'Thumbnails/flowers.png', - 'Thumbnails/heart.png', - 'Thumbnails/liking.png', - 'Thumbnails/party.png', - 'Thumbnails/poke.png', - 'Thumbnails/superlike.png', - 'Thumbnails/victory.png', + require('./Thumbnails/like.png'), + require('./Thumbnails/dislike.png'), + require('./Thumbnails/call.png'), + require('./Thumbnails/fist.png'), + require('./Thumbnails/bandaged.png'), + require('./Thumbnails/flowers.png'), + require('./Thumbnails/heart.png'), + require('./Thumbnails/liking.png'), + require('./Thumbnails/party.png'), + require('./Thumbnails/poke.png'), + require('./Thumbnails/superlike.png'), + require('./Thumbnails/victory.png'), ]; var ListViewGridLayoutExample = React.createClass({ @@ -74,9 +74,7 @@ var ListViewGridLayoutExample = React.createClass({ _renderRow: function(rowData: string, sectionID: number, rowID: number) { var rowHash = Math.abs(hashCode(rowData)); - var imgSource = { - uri: THUMB_URLS[rowHash % THUMB_URLS.length], - }; + var imgSource = THUMB_URLS[rowHash % THUMB_URLS.length]; return ( this._pressRow(rowID)} underlayColor="transparent"> diff --git a/Examples/UIExplorer/ListViewPagingExample.js b/Examples/UIExplorer/ListViewPagingExample.js index 7d0ac98f2..f6cdcae62 100644 --- a/Examples/UIExplorer/ListViewPagingExample.js +++ b/Examples/UIExplorer/ListViewPagingExample.js @@ -34,19 +34,19 @@ var { var PAGE_SIZE = 4; var THUMB_URLS = [ - 'Thumbnails/like.png', - 'Thumbnails/dislike.png', - 'Thumbnails/call.png', - 'Thumbnails/fist.png', - 'Thumbnails/bandaged.png', - 'Thumbnails/flowers.png', - 'Thumbnails/heart.png', - 'Thumbnails/liking.png', - 'Thumbnails/party.png', - 'Thumbnails/poke.png', - 'Thumbnails/superlike.png', - 'Thumbnails/victory.png', - ]; + require('./Thumbnails/like.png'), + require('./Thumbnails/dislike.png'), + require('./Thumbnails/call.png'), + require('./Thumbnails/fist.png'), + require('./Thumbnails/bandaged.png'), + require('./Thumbnails/flowers.png'), + require('./Thumbnails/heart.png'), + require('./Thumbnails/liking.png'), + require('./Thumbnails/party.png'), + require('./Thumbnails/poke.png'), + require('./Thumbnails/superlike.png'), + require('./Thumbnails/victory.png'), +]; var NUM_SECTIONS = 100; var NUM_ROWS_PER_SECTION = 10; @@ -74,9 +74,9 @@ var Thumb = React.createClass({ - - - + + + {this.state.dir === 'column' ? Oooo, look at this new text! So awesome it may just be crazy.