From 5614a04cbadec795b8be61cee462d83024cd13f4 Mon Sep 17 00:00:00 2001 From: Christopher Dro Date: Wed, 24 Jun 2015 09:47:48 -0700 Subject: [PATCH] [RCTConvert] Sort mapping keys alphabetically in RCTLogError Summary: Closes https://github.com/facebook/react-native/pull/1679 Github Author: Christopher Dro Test Plan: Imported from GitHub, without a `Test Plan:` line. --- React/Base/RCTConvert.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/React/Base/RCTConvert.m b/React/Base/RCTConvert.m index 201b783cb..b54aee9d3 100644 --- a/React/Base/RCTConvert.m +++ b/React/Base/RCTConvert.m @@ -187,7 +187,7 @@ NSNumber *RCTConvertEnumValue(const char *typeName, NSDictionary *mapping, NSNum } id value = mapping[json]; if (!value && [json description].length > 0) { - RCTLogError(@"Invalid %s '%@'. should be one of: %@", typeName, json, [mapping allKeys]); + RCTLogError(@"Invalid %s '%@'. should be one of: %@", typeName, json, [[mapping allKeys] sortedArrayUsingSelector: @selector(caseInsensitiveCompare:)]); } return value ?: defaultValue; }