kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-08 07:53:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

iOS downgrade invalid bridge warning (#23557)

Browse Source 
Summary:
I downgrade the invalid bridge warning because I believe that it is a pain that every time that the JS gets refreshed this warnings are being thrown. If the project increase size and more and more NativeModules are added this warnings just spam the emulator or the device.

I understand the reason of validating if the bridge is valid. However in case of invalidness nothing is done, just the warning is thrown. Hence, the reason of downgrading it to improve the development process.

The error message still exist and it will be in the logs. But it will not spam the development screen

[iOS] [Changed] - Downgrade the Invalid bridge warning message to a log
Pull Request resolved: https://github.com/facebook/react-native/pull/23557

Differential Revision: D14161290

Pulled By: cpojer

fbshipit-source-id: e5608a9b2db5625309fd18d133fe69a9013043f3
This commit is contained in:
Agustin Collazo
2019-02-20 18:53:43 -08:00
committed by Facebook Github Bot
parent 468ae234a6
commit 536045276c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
React/CxxModule/RCTNativeModule.mm
View File

@@ -79,7 +79,7 @@ void RCTNativeModule::invoke(unsigned int methodId, folly::dynamic &&params, int
dispatch_async(queue, block);
}
} else {
RCTLogWarn(@"Attempted to invoke `%u` (method ID) on `%@` (NativeModule name) with an invalid bridge.",
RCTLog(@"Attempted to invoke `%u` (method ID) on `%@` (NativeModule name) with an invalid bridge.",
methodId, m_moduleData.name);
}
}